Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests on Windows #246

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Enable tests on Windows #246

merged 1 commit into from
Jun 11, 2023

Conversation

garrison
Copy link
Member

I realized that the entirety of circuit cutting works on Windows, so we might as well advertise native Windows support and test on it too.

Specific changes in this PR:

  • skip tests that require pyscf if it is not available
  • add Windows workflow to Actions matrix
  • add Windows to README platform badge

- skip tests that require pyscf if it is not available
- add Windows workflow to Actions matrix
- add Windows to README platform badge
@garrison garrison added the tests Related to tests label Jun 11, 2023
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5232887074

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.63%

Totals Coverage Status
Change from base Build 5212686650: 0.0%
Covered Lines: 2325
Relevant Lines: 2594

💛 - Coveralls

@garrison garrison marked this pull request as ready for review June 11, 2023 01:45
@garrison garrison requested a review from caleb-johnson June 11, 2023 01:46
Copy link
Collaborator

@caleb-johnson caleb-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@garrison garrison merged commit 3f036e2 into main Jun 11, 2023
@garrison garrison deleted the test-on-windows branch June 11, 2023 20:09
caleb-johnson pushed a commit that referenced this pull request Jun 12, 2023
- skip tests that require pyscf if it is not available
- add Windows workflow to Actions matrix
- add Windows to README platform badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants